linux-kernel - Re: [PATCH] x86_64: simplify the memtest parameter setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440804182017r4fe78371w3a4a714a44591223@mail.gmail.com>
Date:	Fri, 18 Apr 2008 20:17:37 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Frans Pop" <elendil@...net.nl>
Cc:	"Yinghai Lu" <yhlu.kernel.send@...il.com>, mingo@...e.hu,
	akpm@...ux-foundation.org, tglx@...utronix.de, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: simplify the memtest parameter setting

On Fri, Apr 18, 2008 at 7:15 PM, Frans Pop <elendil@...net.nl> wrote:
> On Saturday 19 April 2008, Frans Pop wrote:
>  > Yinghai Lu wrote:
>  > > -config MEMTEST_BOOTPARAM
>  > > -   bool "Memtest boot parameter"
>  > > +config MEMTEST
>  > > +   bool "Memtest"
>  > >  depends on X86_64
>  > >  default y
>  >
>  > With this patch, this default no longer makes any sense.
>  >
>  > >  help
>  > >  This option adds a kernel parameter 'memtest', which allows memtest
>  > > -     to be disabled at boot.  If this option is selected, memtest
>  > > -     functionality can be disabled with memtest=0 on the kernel
>  > > -     command line.  The purpose of this option is to allow a single
>  > > -     kernel image to be distributed with memtest built in, but not
>  > > -     necessarily enabled.
>  > > -
>  > > +     to be set.
>  > > +           memtest=0, mean disabled; -- default
>  > > +           memtest=1, mean do 1 test pattern;
>  > > +           ...
>  > > +           memtest=4, mean do 4 test patterns.
>  >
>  > s/mean/means/
>  > s/; -- default/ (default)/
>
>  These are still good (IMO).
>
>
>  > Maybe some explanation of what a "test pattern" is would be useful.
>  >
>  > >  If you are unsure how to answer this question, answer Y.
>  >
>  > Also makes no sense anymore.
>
>  Oops. Just see I was too fast. After reading it again I see that the y/n
>  value is correct after all.
>
>  However, it also means that the new description is probably too short.
>  The phrase "allows memtest to be set" does not really mean anything to a
>  user who does not know what memtest really does. It also does not explain
>  that memtest is a boot parameter.
>
>  Also, it should probably be made more explicit that no memtest is actually
>  performed unless the memtest boot parameter is passed at the boot prompt.
>
>  Looks like 4 is the maximum possible value. This should be mentioned
>  explicitly (here as well as in Documentation/kernel-parameters.txt).

current it only support 4 pattern, will try to move memtester pattern
into it later...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/