linux-kernel - Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18441.28496.84724.411784@cargo.ozlabs.ibm.com>
Date:	Sat, 19 Apr 2008 14:04:32 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Jochen Friedrich <jochen@...am.de>
Cc:	Kumar Gala <galak@...nel.crashing.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Scott Wood <scottwood@...escale.com>,
	"Kernel, Linux" <linux-kernel@...r.kernel.org>,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	Linux I2C <i2c@...sensors.org>, Jon Smirl <jonsmirl@...il.com>,
	Laurent Pinchart <laurentp@...-semaphore.com>,
	David Miller <davem@...emloft.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

Jochen Friedrich writes:

> Fix build breakage introduced in commit
> "[POWERPC] i2c: OF helpers for the i2c API".
> If i2c-core is compiled as module, the helper needs to be
> compiled as module, as well. Rename i2c.c to of_i2c.c to
> avoid name space conflict.

Actually, since only powerpc has irq_of_parse_and_map, I'm now
inclined to think that drivers/of/i2c.c should live under arch/powerpc
for now, or at the least its option should depend on PPC_OF.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/