linux-kernel - Re: [PATCH 01/15] ARM minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080419081712.GA8523@flint.arm.linux.org.uk>
Date:	Sat, 19 Apr 2008 09:17:13 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk, kernel@...tstofly.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/15] ARM minor irq handler cleanups

On Fri, Apr 18, 2008 at 07:22:45PM -0400, Jeff Garzik wrote:
> Avoid confusion by /not/ passing an unused pointer to
> arm_rtc_interrupt()
> 
> This change's main purpose is to prepare for the patchset in
> jgarzik/misc-2.6.git#irq-remove, that explores removal of the
> never-used 'irq' argument in each interrupt handler.

I don't see how these two things are connected.  Yes, it's true that
this RTC driver doesn't use 'dev_id' but that's an entirely separate
issue to removing the 'int irq' argument.

As I see it, this change is just unnecessarily adding to your workload
for this patch set.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/