linux-kernel - Re: [PATCH][trivial] mm/pagewalk.c break const constraint.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080419184918.A8EE.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Sat, 19 Apr 2008 18:50:46 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	"Vegard Nossum" <vegard.nossum@...il.com>
Cc:	kosaki.motohiro@...fujitsu.com, "Matt Mackall" <mpm@...enic.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH][trivial] mm/pagewalk.c break const constraint.

Hi

> >  when compile 2.6.25, following warnings was outputed.
> >
> >   CC      mm/pagewalk.o
> >  mm/pagewalk.c: In function 'walk_page_range':
> >  mm/pagewalk.c:111: warning: passing argument 1 of 'pgd_offset' discards qualifiers from p\
> >  ointer target type
> >
> >  mm argument of walk_page_range() is unnecessary const restriction.
> >  this patch is no functional change. it's only remove warning.
> 
> Is this ia64 or cris? 

Yes, I use IA64.

> I think the correct way to resolve this is to
> make pgd_offset() take a const struct mm_struct * instead.

that makes sense.
OK, I will make patch again.

Thank you for very good opinion.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/