linux-kernel - Re: [GIT PATCH] SCSI updates for 2.6.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480B4E97.9030805@s5r6.in-berlin.de>
Date:	Sun, 20 Apr 2008 16:09:27 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Matthew Wilcox <matthew@....cx>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Adrian Bunk <bunk@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [GIT PATCH] SCSI updates for 2.6.25

Matthew Wilcox wrote:
> --- a/Documentation/kbuild/kconfig-language.txt
> +++ b/Documentation/kbuild/kconfig-language.txt
> @@ -104,9 +104,9 @@ applicable everywhere (see syntax).
>    Reverse dependencies can only be used with boolean or tristate
>    symbols.
>    Note:
> -	select is evil.... select will by brute force set a symbol
> -	equal to 'y' without visiting the dependencies. So abusing
> -	select you are able to select a symbol FOO even if FOO depends
> +	select should be used with care.  It can set a symbol
> +	without visiting the dependencies.  By abusing select you are
> +	able to select a symbol FOO even if FOO depends
>  	on BAR that is not set. In general use select only for
>  	non-visible symbols (no prompts anywhere) and for symbols with
>  	no dependencies. That will limit the usefulness but on the

"It can set a symbol without visiting the dependencies." = imprecise

"select will by brute force set a symbol [...] without visiting the 
dependencies." = clear.  So why not leave this portion of the text as it is.

Maybe change
	"equal to 'y'"
to
	"equal to 'y' or 'm'"
or to
	""
to make it entirely correct.
-- 
Stefan Richter
-=====-==--- -=-- =-=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/