linux-kernel - Re: + nfsd-use-proc_create-to-setup-de-proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Apr 2008 22:48:48 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	"Denis V. Lunev" <den@...nvz.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	bfields@...ldses.org, ebiederm@...ssion.com, neilb@...e.de
Subject: Re: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to
	-mm tree

On Sun, Apr 20, 2008 at 08:21:49PM +0400, Denis V. Lunev wrote:
> 
> On Sun, 2008-04-20 at 18:37 +0400, Alexey Dobriyan wrote:
> > On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@...ux-foundation.org wrote:
> > > --- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops
> > > +++ a/fs/nfsd/nfsctl.c
> > 
> > > @@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi
> > >  	entry = proc_mkdir("fs/nfs", NULL);
> > >  	if (!entry)
> > >  		return -ENOMEM;
> > > -	entry = create_proc_entry("fs/nfs/exports", 0, NULL);
> > > +	entry = proc_create("exports", 0, entry, &exports_operations);
> > 			    ^^^^^^^^^
>                                            ^^^^^^^
> > >  	if (!entry)
> > >  		return -ENOMEM;
> > > -	entry->proc_fops =  &exports_operations;
> > 
> > "fs/nfs/exports" is used in full in this file. And line will fit into
> > 80 columns.
> > 
> This is a pde for fs/nfs.

Yes, why change it?

> So, this will be slightly less operations in my case.

It's done once per module loading, so nobody cares.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/