linux-kernel - Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0804201933560.11455@topaz.pathscale.com>
Date:	Sun, 20 Apr 2008 19:35:17 -0700 (PDT)
From:	Dave Olson <dave.olson@...gic.com>
To:	Roland Dreier <rdreier@...co.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Ralph Campbell <ralph.campbell@...gic.com>,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, general@...ts.openfabrics.org
Subject: Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git

On Sun, 20 Apr 2008, Roland Dreier wrote:
|  > | so clearly ipath_init_iba7220_funcs() was intended to be built and used
|  > | even if CONFIG_PCI_MSI was not defined.  From the code it looks like all
|  > | should work fine if PCI_MSI is not set, so I don't know what you mean
|  > | about conditional checks.
|  > 
|  > Actually, it wasn't.  It was a late cleanup for another problem, and
|  > we didn't worry about the other issue, and should have.
| 
| Sorry, I still don't follow.  What is the antecedent of "it"?  What was
| "the other issue"?

The CONFIG_PCI_MSI check where init_iba7220 is called.

| I'm not sure I know the right fix for the build breakage.  It seems
| there are two possibilities:
| 
|  - build the iba7220 support unconditionally (the patch I posted).

Yep; I already said I was OK with that.  It's simplest, let's go with it.

| And given that at least some device support works even if neither
| PCI_MSI nor HT_IRQ is defined, then it makes sense to me to remove that
| Kconfig dependency.

Go ahead.

Dave Olson
dave.olson@...gic.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/