linux-kernel - Re: Voyager phys_cpu_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080421132705.GG6011@cs181133002.pp.htv.fi>
Date:	Mon, 21 Apr 2008 16:27:05 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Alexey Starikovskiy <astarikovskiy@...e.de>, tglx@...utronix.de,
	hpa@...or.com, James.Bottomley@...senPartnership.com,
	linux-kernel@...r.kernel.org
Subject: Re: Voyager phys_cpu_present_map compile error

On Mon, Apr 21, 2008 at 02:00:54PM +0200, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@...nel.org> wrote:
> 
> > I shouldn't send bug reports at 3 in the morning...
> > 
> > Attached is the .config for both Voyager build errors I reported.
> 
> thanks, the three patches below should fix it.
>...
> 	Ingo
>...
> --- linux-x86.q.orig/arch/x86/kernel/setup.c
> +++ linux-x86.q/arch/x86/kernel/setup.c
> @@ -21,8 +21,10 @@ EXPORT_SYMBOL(boot_cpu_physical_apicid);
>  DEFINE_PER_CPU(u16, x86_cpu_to_apicid) = BAD_APICID;
>  EXPORT_PER_CPU_SYMBOL(x86_cpu_to_apicid);
>  
> +#ifndef CONFIG_X86_VOYAGER
>  /* Bitmask of physically existing CPUs */
>  physid_mask_t phys_cpu_present_map;
> +#endif
>...

Alexey noted that phys_cpu_present_map for Voyager and !Voyager also 
have different types and suggested to make the Voyager one static 
instead (additional renaming of the Voyager one also makes sense).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/