linux-kernel - Re: [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static

Open Source and information security mailing list archives

Message-ID: <480CCBEC.3080905@oracle.com>
Date:	Mon, 21 Apr 2008 10:16:28 -0700
From:	Sunil Mushran <Sunil.Mushran@...cle.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Joel Becker <joel.becker@...cle.com>,
	Mark Fasheh <mfasheh@...e.com>, linux-kernel@...r.kernel.org,
	ocfs2-devel@....oracle.com
Subject: Re: [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions
 static

Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - stringify_lockname()
> - dlm_debug_put()
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>   

Acked-by: Sunil Mushran <sunil.mushran@...cle.com>

> ---
>
>  fs/ocfs2/dlm/dlmdebug.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> fec83555cf8467e5c932fa52177b8f567eb84d94 diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
> index 5f6d858..1b81dcb 100644
> --- a/fs/ocfs2/dlm/dlmdebug.c
> +++ b/fs/ocfs2/dlm/dlmdebug.c
> @@ -44,7 +44,8 @@
>  #define MLOG_MASK_PREFIX ML_DLM
>  #include "cluster/masklog.h"
>  
> -int stringify_lockname(const char *lockname, int locklen, char *buf, int len);
> +static int stringify_lockname(const char *lockname, int locklen, char *buf,
> +			      int len);
>  
>  void dlm_print_one_lock_resource(struct dlm_lock_resource *res)
>  {
> @@ -251,7 +252,8 @@ EXPORT_SYMBOL_GPL(dlm_errname);
>   *
>   * For more on lockname formats, please refer to dlmglue.c and ocfs2_lockid.h.
>   */
> -int stringify_lockname(const char *lockname, int locklen, char *buf, int len)
> +static int stringify_lockname(const char *lockname, int locklen, char *buf,
> +			      int len)
>  {
>  	int out = 0;
>  	__be64 inode_blkno_be;
> @@ -368,7 +370,7 @@ static void dlm_debug_free(struct kref *kref)
>  	kfree(dc);
>  }
>  
> -void dlm_debug_put(struct dlm_debug_ctxt *dc)
> +static void dlm_debug_put(struct dlm_debug_ctxt *dc)
>  {
>  	if (dc)
>  		kref_put(&dc->debug_refcnt, dlm_debug_free);
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@....oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives