linux-kernel - Re: 2.6.25-mm1 (snd-pcsp causes driver conflict)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480CD281.6050902@aknet.ru>
Date:	Mon, 21 Apr 2008 21:44:33 +0400
From:	Stas Sergeev <stsp@...et.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Takashi Iwai <tiwai@...e.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Joseph Fannin <jfannin@...il.com>,
	linux-kernel@...r.kernel.org, Greg KH <greg@...ah.com>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: 2.6.25-mm1 (snd-pcsp causes driver conflict)

Hello.

Takashi Iwai wrote:
> [Added snd-pcsp author to Cc]
Thanks.

> Seems that snd-pcsp registers as "pcspkr", which is identical with
> input pc-speaker driver.  Does the patch below fix the problem?
Actually it does not. The reason is that
then it fails to match the platform device,
which is created in arch/x86/kernel/pcspeaker.c,
with the name of "pcspkr".

But we already had the patch for that in an
alsa tree, it probably got forgotten. Here
it is:
http://hg-mirror.alsa-project.org/alsa-driver/raw-file/90eeee75052f/utils/patches/pcsp-kernel-2.6.22-01.diff

Also attaching it here.
It simply disables the pcspkr driver in
Kconfig. snd-pcsp has the copy of that
driver, so that only one driver would
drive the device.

Does that fix look good? (presumably acked
by Takashi, otherwise the patch wouldn't
be in an alsa tree)

---------------

- Prevent pcspkr driver from being built
together with snd-pcsp. snd-pcsp fully
superceeds pcspkr.
- Update CREDITS file. :)

Signed-off-by: Stas Sergeev <stsp@...et.ru>
Acked-by: Takashi Iwai <tiwai@...e.de>

View attachment "pcsp-kernel-2.6.24-01.diff" of type "text/x-patch" (1249 bytes)