linux-kernel - Re: Voyager phys_cpu_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080421195517.GH8770@elte.hu>
Date:	Mon, 21 Apr 2008 21:55:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Adrian Bunk <bunk@...nel.org>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	tglx@...utronix.de, James.Bottomley@...senPartnership.com,
	linux-kernel@...r.kernel.org
Subject: Re: Voyager phys_cpu_present_map compile error


* H. Peter Anvin <hpa@...or.com> wrote:

>> thanks, the three patches below should fix it.
>>
>> i ended up excluding Voyager configs from our test space some time 
>> ago (and VISWS as well - there's one more visws fix in x86.git), 
>> that's how this broke. These subarchitectures seem not to be used at 
>> all and the code wont boot on normal PCs. We could mark it BROKEN but 
>> the fix seems simple in any case.
>
> I talked to jejb about this, and pretty much the consensus was that if 
> it breaks, mark it BROKEN, and let him come back and catch up.  Under 
> those conditions, I'm willing to keep it in the tree.

sure - but no need to be rude and mark it BROKEN when we've got this 
much better tool named "email". BROKEN is really just for cases where 
there's no-one willing to fix things.

> VISWS is another matter.  It's entirely possible I have the only 
> remaining VISWS in my garage; we have at least not been able to locate 
> another.  Not that we have tried all that hard.
>
> If there are no VISWS' left, we should just unload the code.

ok, but there we should first mark it BROKEN, and after 1-2 kernel 
releases remove it so that there's adequate notice.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/