linux-kernel - Re: [PATCH] kgdb: fix signedness mixmatches, add statics, add declaration to header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <480CF7E0.8060906@windriver.com>
Date:	Mon, 21 Apr 2008 15:24:00 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kgdb: fix signedness mixmatches, add statics, add	declaration
 to header

Harvey Harrison wrote:
> Noticed by sparse:
> arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
> kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static?
> kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
> kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static?
>
> Related to kgdb_hex2long:
> arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 (different signedness)
> arch/x86/kernel/kgdb.c:371:28:    expected long *long_val
> arch/x86/kernel/kgdb.c:371:28:    got unsigned long *<noident>
> kernel/kgdb.c:469:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:469:27:    expected long *long_val
> kernel/kgdb.c:469:27:    got unsigned long *<noident>
> kernel/kgdb.c:470:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:470:27:    expected long *long_val
> kernel/kgdb.c:470:27:    got unsigned long *<noident>
> kernel/kgdb.c:894:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:894:27:    expected long *long_val
> kernel/kgdb.c:894:27:    got unsigned long *<noident>
> kernel/kgdb.c:895:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:895:27:    expected long *long_val
> kernel/kgdb.c:895:27:    got unsigned long *<noident>
> kernel/kgdb.c:1127:28: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:1127:28:    expected long *long_val
> kernel/kgdb.c:1127:28:    got unsigned long *<noident>
> kernel/kgdb.c:1132:25: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:1132:25:    expected long *long_val
> kernel/kgdb.c:1132:25:    got unsigned long *<noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
>   

This patch looked fine Harvey, I queued it for the next pull request at:

http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=shortlog;h=for_linus

Jason.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/