linux-kernel - Re: [git patches] minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080421074240.GA1938@flint.arm.linux.org.uk>
Date:	Mon, 21 Apr 2008 08:42:41 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, kernel@...tstofly.org,
	linux-arm-kernel@...ts.arm.linux.org.uk, galak@...nel.crashing.org,
	David Miller <davem@...emloft.net>, kkeil@...e.de,
	isdn4linux@...tserv.isdn4linux.de, cooloney@...nel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [git patches] minor irq handler cleanups

On Sun, Apr 20, 2008 at 09:35:51PM -0400, Jeff Garzik wrote:
> diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c
> index 5278f58..5235f64 100644
> --- a/arch/arm/mach-integrator/time.c
> +++ b/arch/arm/mach-integrator/time.c
> @@ -125,7 +125,7 @@ static int rtc_probe(struct amba_device *dev, void *id)
>  	xtime.tv_sec = __raw_readl(rtc_base + RTC_DR);
>  
>  	ret = request_irq(dev->irq[0], arm_rtc_interrupt, IRQF_DISABLED,
> -			  "rtc-pl030", dev);
> +			  "rtc-pl030", NULL);
>  	if (ret)
>  		goto map_out;
>  

BTW, if you're removing the dev_id argument from request_irq(), that
also needs to happen for the corresponding free_irq() calls.
arch/arm/mach-integrator/time.c does:

        free_irq(dev->irq[0], dev);

and these are untouched.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/