linux-kernel - Re: False positive in checkpatch (2.6.25)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080422080547.GC26446@shadowen.org>
Date:	Tue, 22 Apr 2008 09:05:47 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: False positive in checkpatch (2.6.25)

On Thu, Apr 17, 2008 at 03:33:48PM -0400, Alan Stern wrote:

> ERROR: space prohibited after that '*' (ctx:ExW)
> #15: FILE: drivers/usb/core/driver.c:1544:
> +        * when the system suspend started, so we don't want to resume it
>          ^
> 
> ERROR: Missing Signed-off-by: line(s)

Yes, pretty sure that was triggered by a bug in comment tracking when
it moved into quote tracking.  From my testing here it should have been
fixed in v0.17, you have v0.16.  Andrew has the change queued up so it
should be on its way to mainline.  You can get the latest from the url
below to confirm:

	http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/

Thanks for the report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/