linux-kernel - Re: [PATCH 1/2] ALSA: Fix synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4p9ub1kz.wl%tiwai@suse.de>
Date:	Tue, 22 Apr 2008 12:55:56 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	perex@...ex.cz, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] ALSA: Fix synchronize_irq() bugs, redundancies

At Mon, 21 Apr 2008 19:34:19 -0400,
Jeff Garzik wrote:
> 
> free_irq() calls synchronize_irq() for you, so there is no need for
> drivers to manually do the same thing (again).  Thus, calls where
> sync-irq immediately precedes free-irq can be simplified.
> 
> However, during this audit several bugs were noticed, where free-irq is
> preceded by a "irq >= 0" check... but the sync-irq call is not covered
> by the same check.
> 
> So, where sync-irq could not be eliminated completely, the missing check
> was added.
> 
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

Thanks, I applied to ALSA tree now.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/