| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <878wz6jdpb.fsf@duaron.myhome.or.jp> Date: Tue, 22 Apr 2008 21:06:56 +0900 From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org Subject: [PATCH] Fix unconditional write_super() call in file_fsync() This fixes file_fsync(). we need to check ->s_dirt before calling write_super(). It became the cause of an unneeded write. This bug was noticed by Sudhanshu Saxena. Signed-off-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> --- fs/sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/sync.c~file_fsync-fix fs/sync.c --- linux-2.6/fs/sync.c~file_fsync-fix 2008-04-22 15:14:50.000000000 +0900 +++ linux-2.6-hirofumi/fs/sync.c 2008-04-22 15:16:58.000000000 +0900 @@ -64,7 +64,7 @@ int file_fsync(struct file *filp, struct /* sync the superblock to buffers */ sb = inode->i_sb; lock_super(sb); - if (sb->s_op->write_super) + if (sb->s_dirt && sb->s_op->write_super) sb->s_op->write_super(sb); unlock_super(sb); _ -- OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists