linux-kernel - Re: kgdb: fix optional arch functions and probe_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080422130720.GA7311@elte.hu>
Date:	Tue, 22 Apr 2008 15:07:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: kgdb: fix optional arch functions and probe_kernel_*


* Jason Wessel <jason.wessel@...driver.com> wrote:

> >> Still.  Do we need the set_fs() in there?  
> >> __copy_from_user_inatomic() is a "__" uaccess function and hence 
> >> shouldn't be running access_ok()?
> >
> > yeah, i guess that's true. Jason?
> 
> In so far as the testing showed, it worked ok on the X86 arch with and 
> without the set_fs(), but on ARM it is absolutely required.  This 
> means we have to decide to make arch specific or leave generic as it 
> stands right now.

yeah, i guess so - it's no big issue as this isnt performance critical 
in any way. Do you know which exact codepath/mechanism in ARM relies on 
the set_fs() being there?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/