linux-kernel - Re: [PATCH] SELinux fixups needed for preemptable RCU from -rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0804212053530.25185@gandalf.stny.rr.com>
Date:	Mon, 21 Apr 2008 20:54:51 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
cc:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	akpm@...ux-foundation.org, dwalker@...sta.com,
	sdietrich@...ell.com, dvhltc@...ibm.com, niv@...ibm.com
Subject: Re: [PATCH] SELinux fixups needed for preemptable RCU from -rt


On Mon, 21 Apr 2008, Paul E. McKenney wrote:
> @@ -807,8 +810,14 @@ int avc_ss_reset(u32 seqno)
>
>  	for (i = 0; i < AVC_CACHE_SLOTS; i++) {
>  		spin_lock_irqsave(&avc_cache.slots_lock[i], flag);
> +		/*
> +		 * On -rt the outer spinlock does not prevent RCU
> +		 * from being performed:

I would suggest to change this comment to "With preemptible RCU" from
"On -rt".

-- Steve

> +		 */
> +		rcu_read_lock();
>  		list_for_each_entry(node, &avc_cache.slots[i], list)
>  			avc_node_delete(node);
> +		rcu_read_unlock();
>  		spin_unlock_irqrestore(&avc_cache.slots_lock[i], flag);
>  	}
>
5A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/