linux-kernel - Re: [PATCH] Fix x86_64 page fault scheduler race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080422141909.GE24966@elte.hu>
Date:	Tue, 22 Apr 2008 16:19:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	akpm@...l.org, "H. Peter Anvin" <hpa@...or.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	"Frank Ch. Eigler" <fche@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix x86_64 page fault scheduler race


* Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> > the scheduler disables interrupts around __switch_to(). (x86 does 
> > not set __ARCH_WANT_INTERRUPTS_ON_CTXSW)
> 
> Ok, so I guess it's only useful to NMIs then. However, it makes me 
> wonder why this comment was there in the first place on x86_32 
> vmalloc_fault() and why it uses read_cr3() :
> 
>         * Do _not_ use "current" here. We might be inside
>         * an interrupt in the middle of a task switch..

hm, i guess it's still useful to keep the 
__ARCH_WANT_INTERRUPTS_ON_CTXSW case working too. On -rt we used to 
enable it to squeeze a tiny bit more latency out of the system.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/