[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080422015342.GA9591@hash.localnet>
Date: Mon, 21 Apr 2008 21:53:42 -0400
From: Bob Copeland <me@...copeland.com>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: akpm@...ux-foundation.org, hch@...radead.org,
alan@...rguk.ukuu.org.uk, marcin.slusarz@...il.com,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 5/8] omfs: add file routines
On Mon, Apr 21, 2008 at 05:29:12PM +0200, Miklos Szeredi wrote:
> This instead?
>
> if (offset > 0) {
> ret = 0;
> map_bh(bh_result, inode->i_sb, offset);
> if (remain > max_blocks)
> remain = max_blocks;
> bh_result->b_size = (remain << inode->i_blkbits);
> goto out_brelse;
> }
Much cleaner, thanks!
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists