linux-kernel - Re: cdrom: use kmalloced buffers instead of buffers on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080421.190331.58435430.davem@davemloft.net>
Date:	Mon, 21 Apr 2008 19:03:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	linux-kernel@...r.kernel.org, jens.axboe@...cle.com,
	tsbogend@...ha.franken.de, akpm@...ux-foundation.org
Subject: Re: cdrom: use kmalloced buffers instead of buffers on stack

From: Jeff Garzik <jeff@...zik.org>
Date: Mon, 21 Apr 2008 22:01:26 -0400

> Eh... AFAICS this is only really useful in two of the cases converted.
> 
> For all the other cases (<= 32 bytes), it is _far_ less complex, far 
> less code to simply communicate the additional alignment requirements to 
> the compiler.
> 
> What about __attribute__ __aligned__?  Was that tried?

On some platforms the stack is virtually mapped instead of
from kmalloc or get_free_pages memory.

DMA on stack buffers is really not feasible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/