linux-kernel - Re: [PATCH] mfd: kconfig exposing unbuildable driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0804221359360.2779@woody.linux-foundation.org>
Date:	Tue, 22 Apr 2008 14:05:29 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Russell King <rmk+lkml@....linux.org.uk>
cc:	Harvey Harrison <harvey.harrison@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [PATCH] mfd: kconfig exposing unbuildable driver

On Tue, 22 Apr 2008, Russell King wrote:
>
> That was my initial approach as well, which got shot down by Andrew
> Morton and others as being unacceptable.

Hmm. While I in general support the notion of trying to compile drivers on 
as wide a variety as hardware as possible, if that HTC_PASIC3 thing really 
is a PXA-only piece of hardware, I don't really see the point of not 
making the config file accurately represent that.

That said, as far as I can tell, the compile failure is because of this 
line:

	#include <asm/arch/pxa-regs.h>

and I cannot for the life of me see _why_ it tries to include that header 
file. It seems to compile fine on x96-64 if you just remove that include, 
and while I still think it should depend on ARCH_PXA just because it makes 
no sense _not_ to, I do wonder why that include is there in the first 
place.

Hmm?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/