linux-kernel - Re: [PATCH] xfs: remove unused params from functions in xfs/quota/*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080422230835.GY108924158@sgi.com>
Date:	Wed, 23 Apr 2008 09:08:35 +1000
From:	David Chinner <dgc@....com>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	David Chinner <dgc@....com>, Eric Sandeen <sandeen@...deen.net>,
	Adrian Bunk <bunk@...nel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Shawn Bohrer <shawn.bohrer@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] xfs: remove unused params from functions in xfs/quota/*

On Tue, Apr 22, 2008 at 03:40:12PM +0200, Denys Vlasenko wrote:
> Hi David,
> 
> This patch deals with remaining cases of unused parameters in fs/xfs/quota/*
> as far as I can see so far. The rest of unused parameters
> in fs/xfs/quota/* cannot be easily eliminated due to addresses
> of functions being taken.

I'd just kill the parameters to xfs_qm_hold_quotafs_ref and
xfs_qm_rele_quotafs_ref and I wouldn't worry about removingthe debug-only
id parameter to xfs_qm_dqread as it's not in a stack critical path.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/