linux-kernel - Re: [PATCH] fix brd allocation flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080422033423.GD21993@wotan.suse.de>
Date:	Tue, 22 Apr 2008 05:34:23 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Petr Tesarik <ptesarik@...e.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix brd allocation flags

On Thu, Apr 17, 2008 at 11:14:07PM +0200, Petr Tesarik wrote:
> Hello,
> 
> while looking at the implementation of the Ram backed block device
> driver, I stumbled across a write-only local variable, which makes
> little sense, so I assume it should actually work like this:

Right you are. Good catch, thanks Petr.

> 
> Signed-off-by: Petr Tesarik <ptesarik@...e.cz>
> 
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 8536480..7bd7663 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector)
>  #ifndef CONFIG_BLK_DEV_XIP
>  	gfp_flags |= __GFP_HIGHMEM;
>  #endif
> -	page = alloc_page(GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO);
> +	page = alloc_page(gfp_flags);
>  	if (!page)
>  		return NULL;
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/