linux-kernel - Re: [sched-devel/latest] WARNING: at mm/slub.c:2443

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804231038210.26134@sbz-30.cs.Helsinki.FI>
Date:	Wed, 23 Apr 2008 10:38:45 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	Pete Zaitcev <zaitcev@...hat.com>
cc:	Ingo Molnar <mingo@...e.hu>, Frans Pop <elendil@...net.nl>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	gregkh@...e.de
Subject: Re: [sched-devel/latest] WARNING: at mm/slub.c:2443

On Tue, 22 Apr 2008, Pete Zaitcev wrote:
> > Cc:-ing USB folks as the kmem_cache_destroy() comes from 
> > drivers/usb/mon/mon_text.c.
> 
> I looked at this whole day today, but found nothing.
> 
> The code analysis for usbmon shows nothing. Anyone wants to have
> a look?

So something like the following totally untested patch.

		Pekka

diff --git a/drivers/usb/mon/mon_text.c b/drivers/usb/mon/mon_text.c
index 5e3e4e9..c6fdc6e 100644
--- a/drivers/usb/mon/mon_text.c
+++ b/drivers/usb/mon/mon_text.c
@@ -449,6 +449,7 @@ static struct mon_event_text *mon_text_read_wait(struct mon_reader_text *rp,
 		if (file->f_flags & O_NONBLOCK) {
 			set_current_state(TASK_RUNNING);
 			remove_wait_queue(&rp->wait, &waita);
+			kmem_cache_free(rp->e_slab, ep);
 			return ERR_PTR(-EWOULDBLOCK);
 		}
 		/*
@@ -458,6 +459,7 @@ static struct mon_event_text *mon_text_read_wait(struct mon_reader_text *rp,
 		schedule();
 		if (signal_pending(current)) {
 			remove_wait_queue(&rp->wait, &waita);
+			kmem_cache_free(rp->e_slab, ep);
 			return ERR_PTR(-EINTR);
 		}
 		set_current_state(TASK_INTERRUPTIBLE);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/