linux-kernel - Re: Unexport of blk_get_queue and blk_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200804231006.47363.philipp.reisner@linbit.com>
Date:	Wed, 23 Apr 2008 10:06:46 +0200
From:	Philipp Reisner <philipp.reisner@...bit.com>
To:	"Bart Van Assche" <bart.vanassche@...il.com>
Cc:	"Adrian Bunk" <bunk@...nel.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Lars Ellenberg" <lars.ellenberg@...bit.com>
Subject: Re: Unexport of blk_get_queue and blk_put_queue

Am Mittwoch, 23. April 2008 08:12:41 schrieb Bart Van Assche:
> On Mon, Apr 21, 2008 at 2:24 PM, Adrian Bunk <bunk@...nel.org> wrote:
> > On Fri, Apr 18, 2008 at 01:43:17PM +0200, Bart Van Assche wrote:
> >  > I noticed that blk_get_queue and blk_put_queue were unexported in the
> >  > 2.6.25 kernel. Are you aware that this breaks DRBD (an out-of-tree
> >  > kernel module) ?
> >
> >  no, I verify that my patches don't break Linus' tree and often also peek
> >  at -mm, but not at external modules.
> >
> >  And I'm a proponent of "no stable kernel API, but as many external
> >  modules as reasonably possible should be part of the kernel", so emails
> >  like yours are always a good point to start asking why the code isn't in
> >  Linus' tree.
> >
> >  What happened to DRBD?
> >  It didn't seem that far from getting merged half a year ago.
>
> You mean this message: http://lkml.org/lkml/2007/7/21/255 ?
> (Added Lars Ellenberg in CC.)

Hi,

The removal of blk_put_queue() broke DRBD as it was, but it turned out
that we can (and should) use blk_cleanup_queue() instead. That will be
release with drbd-8.0.12, which is scheduled for release tomorrow 
2008-4-24.

Regarding the kernel inclusion. Well yes we still want to go that road,
but we where distracted from that with other tasks.

 (At some point we even hoped that Adrian will be of help in that process
  but that did not worked out as we thought)

We will renew our effort for main line inclusion in the next months somewhen.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/