linux-kernel - Re: [2.6 patch] drivers/firmware/iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804230724.42697.ketuzsezr@darnok.org>
Date:	Wed, 23 Apr 2008 07:24:42 -0400
From:	Konrad Rzeszutek <ketuzsezr@...nok.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Konrad Rzeszutek <ketuzsezr@...nok.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static

On Wednesday 23 April 2008 05:52:30 Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - ibft_attr_show_initiator()
> - ibft_attr_show_nic()
> - ibft_attr_show_target()
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>

Thanks for catching that.

Signed-off-by: Konrad Rzeszutek <ketuzsezr@...nok.org>

>
> ---
>
>  drivers/firmware/iscsi_ibft.c |   18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> 421adc9620a633d461059da9a8a94315d8a767ea diff --git
> a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index
> 8024e3b..8523811 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
>  /*
>   *  Routines for parsing the iBFT data to be human readable.
>   */
> -ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> -				  struct ibft_attribute *attr,
> -				  char *buf)
> +static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> +					struct ibft_attribute *attr,
> +					char *buf)
>  {
>  	struct ibft_initiator *initiator = entry->initiator;
>  	void *ibft_loc = entry->header;
> @@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject
> *entry, return str - buf;
>  }
>
> -ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> -			    struct ibft_attribute *attr,
> -			    char *buf)
> +static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> +				  struct ibft_attribute *attr,
> +				  char *buf)
>  {
>  	struct ibft_nic *nic = entry->nic;
>  	void *ibft_loc = entry->header;
> @@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
>  	return str - buf;
>  };
>
> -ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> -			       struct ibft_attribute *attr,
> -			       char *buf)
> +static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> +				     struct ibft_attribute *attr,
> +				     char *buf)
>  {
>  	struct ibft_tgt *tgt = entry->tgt;
>  	void *ibft_loc = entry->header;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/