linux-kernel - Re: Pull request for semaphore include changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2008 10:03:49 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-kernel@...r.kernel.org,
	David Howells <dhowells@...hat.com>
Subject: Re: Pull request for semaphore include changes

On Wed, Apr 23, 2008 at 08:57:24AM -0700, Roland Dreier wrote:
>  >  drivers/infiniband/core/user_mad.c            |    2 +-
> 
> Let me say up front I have no problem with this change, which moved from
> <asm/semaphore.h> to <linux/semaphore.h>.  So take this email as an
> honest question and not any form of complaint or criticism.  But looking
> at that user_mad.c file in particular, I don't see any use of anything
> that looks like it would come from semaphore.h.

You've missed this hunk:

        if (filp->f_flags & O_NONBLOCK) {
                if (down_trylock(&port->sm_sem)) {
                        ret = -EAGAIN;
                        goto fail;
                }
        } else {
                if (down_interruptible(&port->sm_sem)) {
                        ret = -ERESTARTSYS;
                        goto fail;
                }
        }

which is still in Linus' tree as of last night.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/