[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.58.0804222205110.32718@gandalf.stny.rr.com>
Date: Tue, 22 Apr 2008 22:08:09 -0400 (EDT)
From: Steven Rostedt <rostedt@...dmis.org>
To: LKML <linux-kernel@...r.kernel.org>
cc: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
akpm@...dmis.org, Soeren Sandmann Pedersen <sandmann@...hat.com>,
Pekka Paalanen <pq@....fi>
Subject: [PATCH] ftrace: fix setting of pos in read_pipe
In resetting the iterator in read_pipe, the reset of pos was
postitioned in the wrong location with respect to the memset
operation. The current code sets pos, incorrectly, to zero.
Signed-off-by: Steven Rostedt <srostedt@...hat.com>
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-sched-devel.git/kernel/trace/trace.c
===================================================================
--- linux-sched-devel.git.orig/kernel/trace/trace.c 2008-04-22 10:41:58.000000000 -0400
+++ linux-sched-devel.git/kernel/trace/trace.c 2008-04-22 10:42:41.000000000 -0400
@@ -2500,10 +2500,10 @@ tracing_read_pipe(struct file *filp, cha
cnt = PAGE_SIZE - 1;
/* reset all but tr, trace, and overruns */
- iter->pos = -1;
memset(&iter->seq, 0,
sizeof(struct trace_iterator) -
offsetof(struct trace_iterator, seq));
+ iter->pos = -1;
/*
* We need to stop all tracing on all CPUS to read the
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists