lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <480FAB05.1040107@tiscali.nl>
Date:	Wed, 23 Apr 2008 23:32:53 +0200
From:	Roel Kluin <12o3l@...cali.nl>
To:	pb@...dhelds.org, sameo@...nedhand.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] asic3: platform_get_irq() may return signed unnoticed

asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index f6f2d96..95f7b0c 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -302,7 +302,7 @@ static int asic3_irq_probe(struct platform_device *pdev)
 	unsigned int irq, irq_base;
 
 	asic->irq_nr = platform_get_irq(pdev, 0);
-	if (asic->irq_nr < 0)
+	if (asic->irq_nr == -ENXIO)
 		return asic->irq_nr;
 
 	/* turn on clock to IRQ controller */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ