linux-kernel - [PATCH 2/2] ARM: ax88796: platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480FAED6.7080407@tiscali.nl>
Date:	Wed, 23 Apr 2008 23:49:10 +0200
From:	Roel Kluin <12o3l@...cali.nl>
To:	rmk@....linux.org.uk,
	Linux-arm <linux-arm-kernel@...ts.arm.linux.org.uk>
CC:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed

similarly,
---
dev->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 194949a..26a735a 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
 
 	/* find the platform resources */
 
-	dev->irq  = platform_get_irq(pdev, 0);
-	if (dev->irq < 0) {
+	ret  = platform_get_irq(pdev, 0);
+	dev->irq = ret;
+	if (ret < 0) {
 		dev_err(&pdev->dev, "no IRQ specified\n");
-		ret = -ENXIO;
 		goto exit_mem;
 	}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/