linux-kernel - Re: [PATCH v2] asic3: platform_get_irq() may return signed unnoticed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080423231608.GC18907@caravaggio>
Date:	Thu, 24 Apr 2008 01:16:09 +0200
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	pb@...dhelds.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] asic3: platform_get_irq() may return signed unnoticed

On Thu, Apr 24, 2008 at 12:58:02AM +0200, Roel Kluin wrote:
> Thanks to Joe Perches for catching an error in my previous
Yep, that makes sense now.

> ---
> asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
Acked-by: Samuel Ortiz <sameo@...nedhand.com>

> ---
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index f6f2d96..abd7ffc 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -300,10 +300,13 @@ static int asic3_irq_probe(struct platform_device *pdev)
>  	struct asic3 *asic = platform_get_drvdata(pdev);
>  	unsigned long clksel = 0;
>  	unsigned int irq, irq_base;
> +	int ret;
> +
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret < 0)
> +		return ret;
>  
> -	asic->irq_nr = platform_get_irq(pdev, 0);
> -	if (asic->irq_nr < 0)
> -		return asic->irq_nr;
> +	asic->irq_nr = ret;
>  
>  	/* turn on clock to IRQ controller */
>  	clksel |= CLOCK_SEL_CX;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/