linux-kernel - Re: [PATCH] x86: vm86 - hide X86_VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080424084241.GA8624@cvg>
Date:	Thu, 24 Apr 2008 12:42:41 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs

[David Woodhouse - Thu, Apr 24, 2008 at 09:39:24AM +0100]
| On Thu, 2008-04-24 at 12:35 +0400, Cyrill Gorcunov wrote:
| > X86_VM_MASK is a kernel specific flag so lets hide it from
| > userland programs
| > 
| > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
| 
| Since and there's already an #ifdef __KERNEL__ section later on in the
| file, and since X86_VM_MASK isn't used before that, I probably would
| have been inclined to shift it down there instead of adding a new
| #ifdef.
| 
| But maybe I should just stop heckling... :)
| 
| -- 
| dwmw2
| 

I was thought about that too ;) David, I'll recheck this
all today evening (have to go to office now). And please
continue heckling - it allows to make this file in particular
*better*, so I think it's ok ;)

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/