linux-kernel - Re: [patch 22/53] PNP: factor pnp_init_resource_table() and pnp_clean_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480FE1CB.8000202@keyaccess.nl>
Date:	Thu, 24 Apr 2008 03:26:35 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 22/53] PNP: factor pnp_init_resource_table() and pnp_clean_resource_table()

On 24-04-08 01:08, Bjorn Helgaas wrote:

> My idea is that the list should end up in the same order as the
> resource list from the BIOS, e.g., the _CRS and _PRS lists for
> ACPI.  In the case of ISAPNP, it'll be in the order that we read
> things from the hardware registers.
> 
> I think I should probably make pnp_new_resource() always allocate
> a new resource and get rid of the idea of reusing something already
> in the list.

I'd agree.

> I updated the patches and my ACPI box with the inactive devices now boots
> (it failed with the v3 patches).  I'll work on the pnp_new_resource()
> thing tomorrow, but I'll send you the current patches now in case you
> have a chance to try them on your ISA box.

Could do a quick test and its cs4236 soundcard works fine with them. There 
are a few "current resources: after pnp_assign_resources (failed)" in there 
but they might be expected, I didn't yet look. There's a dmesg from booting 
it and "modprobe snd-cs4236" at:

http://members.home.nl/rene.herman/dmesg-2.6.25-pnpv3.9

Matching "options" files:

root@...p:~# for OPTIONS in /sys/devices/pnp1/01\:01/01\:01.0?/options; do 
echo; echo $OPTIONS; echo; cat $OPTIONS; done

/sys/devices/pnp1/01:01/01:01.00/options

Dependent: 01 - Priority preferred
    port 0x534-0x534, align 0x3, size 0x4, 16-bit address decoding
    port 0x388-0x388, align 0x7, size 0x4, 16-bit address decoding
    port 0x220-0x220, align 0x1f, size 0x10, 16-bit address decoding
    irq 5 High-Edge
    dma 1 8-bit byte-count compatible
    dma 0,1 8-bit byte-count compatible
Dependent: 02 - Priority acceptable
    port 0x534-0xffc, align 0x3, size 0x4, 16-bit address decoding
    port 0x388-0x388, align 0x7, size 0x4, 16-bit address decoding
    port 0x220-0x260, align 0x1f, size 0x10, 16-bit address decoding
    irq 5,7,2/9,11,12,15 High-Edge
    dma 1,3 8-bit byte-count compatible
    dma 0,1,3 8-bit byte-count compatible
Dependent: 03 - Priority functional
    port 0x534-0xffc, align 0x3, size 0x4, 16-bit address decoding
    port 0x388-0x3f8, align 0x7, size 0x4, 16-bit address decoding
    port 0x220-0x300, align 0x1f, size 0x10, 16-bit address decoding
    irq 5,7,2/9,11,12,15 High-Edge
    dma 0,1,3 8-bit byte-count compatible

/sys/devices/pnp1/01:01/01:01.01/options

Dependent: 01 - Priority preferred
    port 0x200-0x200, align 0x7, size 0x8, 16-bit address decoding
Dependent: 02 - Priority acceptable
    port 0x208-0x208, align 0x7, size 0x8, 16-bit address decoding

/sys/devices/pnp1/01:01/01:01.02/options

port 0x120-0xff8, align 0x7, size 0x8, 16-bit address decoding

/sys/devices/pnp1/01:01/01:01.03/options

Dependent: 01 - Priority preferred
    port 0x330-0x330, align 0x7, size 0x2, 16-bit address decoding
    irq 2/9 High-Edge
Dependent: 02 - Priority acceptable
    port 0x330-0x360, align 0x7, size 0x2, 16-bit address decoding
    irq 2/9,11,12,15 High-Edge
Dependent: 03 - Priority functional
    port 0x330-0x3e0, align 0x7, size 0x2, 16-bit address decoding

/sys/devices/pnp1/01:01/01:01.04/options

Dependent: 01 - Priority acceptable
    port 0x1e8-0x1e8, align 0x0, size 0x8, 16-bit address decoding
    port 0x3ee-0x3ee, align 0x0, size 0x1, 16-bit address decoding
    irq 11,12 High-Edge
Dependent: 02 - Priority acceptable
    port 0x168-0x168, align 0x0, size 0x8, 16-bit address decoding
    port 0x36e-0x36e, align 0x0, size 0x1, 16-bit address decoding
    irq 2/9,11,12 High-Edge

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/