linux-kernel - Re: [2.6 patch] remove ata_cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080424104406.GB2559@cs181133002.pp.htv.fi>
Date:	Thu, 24 Apr 2008 13:44:06 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Tejun Heo <htejun@...il.com>, jgarzik@...ox.com,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] remove ata_cable_sata()

On Wed, Apr 23, 2008 at 07:22:43PM +0100, Alan Cox wrote:
> On Mon, 21 Apr 2008 11:51:31 +0300
> Adrian Bunk <bunk@...nel.org> wrote:
> 
> > This patch removes the no longer used ata_cable_sata()
> > 
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> NAK - this one is a sensible part of the driver API

I must have missed something.

I thought that you could simply set .flags in a driver without needing 
any helper for .cable_detect .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/