linux-kernel - Re: [PATCH] Colibri: Fix support for DM9000 ethernet device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2008 12:28:58 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Michael Abbott <michael@...neidae.co.uk>
Cc:	Daniel Mack <daniel@...aq.org>, linux-arm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Colibri: Fix support for DM9000 ethernet device.

On Thu, Apr 24, 2008 at 10:13:09AM +0000, Michael Abbott wrote:
> From: Michael Abbott <michael.abbott@...mond.ac.uk>
>
> Colibri: Fix support for DM9000 ethernet device.
>
> Two changes are necessary to enable proper operation of the DM9000 device
> with the Colibri PXA 270 board: firstly, the IRQ type needs to be
> configured for rising edge interrupts, and secondly this configuration needs
> to be communicated through to the DM9000.
>
> Signed-off-by: Michael Abbott <michael.abbott@...mond.ac.uk>
> ---
>  arch/arm/mach-pxa/colibri.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> Patch applied against v2.6.25
>
> Proper operation of this device also depends on the DM9000 timer patch  
> submitted separately.
>
> diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c
> index 6db54e3..a76f95a 100644
> --- a/arch/arm/mach-pxa/colibri.c
> +++ b/arch/arm/mach-pxa/colibri.c
> @@ -97,7 +97,7 @@ static struct resource dm9000_resources[] = {
>  	[2] = {
>  		.start	= COLIBRI_ETH_IRQ,
>  		.end	= COLIBRI_ETH_IRQ,
> -		.flags	= IORESOURCE_IRQ,
> +		.flags	= IORESOURCE_IRQ | IRQF_TRIGGER_RISING,
>  	},
>  };
>
> @@ -118,7 +118,7 @@ static void __init colibri_init(void)
>  	/* DM9000 LAN */
>  	pxa_gpio_mode(GPIO78_nCS_2_MD);
>  	pxa_gpio_mode(GPIO_DM9000 | GPIO_IN);
> -	set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING);
> +	set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);

The set_irq_type() call here should be removed.

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/