linux-kernel - Re: [PATCH 1/4] capability: capability.h whitespace, syntax, and other cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2008 08:13:56 -0400
From:	Eric Paris <eparis@...hat.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, jmorris@...ei.org
Subject: Re: [PATCH 1/4] capability: capability.h whitespace, syntax, and
	other cleanups

On Wed, 2008-04-23 at 20:54 -0500, Serge E. Hallyn wrote:
> Quoting eparis@...hat.com (eparis@...hat.com):
> > From: Eric Paris <eparis@...hat.com>
> > 
> > This patch changes capability.h to fix whitespace and syntax issues.  Things that
> > are fixed may include (does not not have to include)
> > 
> > whitespace at end of lines
> > spaces followed by tabs
> > spaces used instead of tabs
> > spacing around parenthesis
> > location of { around structs and else clauses
> > location of * in pointer declarations
> > removal of initialization of static data to keep it in the right section
> > useless {} in if statemetns
> > useless checking for NULL before kfree
> > fixing of the indentation depth of switch statements
> > no assignments in if statements
> > include spaces around , in function calls
> > and any number of other things I forgot to mention
> 
> Thanks.  Looks fine other than the inexplicable (afaics)
> jumping of the capability #s by one tab for CAP_NET_ADMIN
> and then again from CAP_IPC_OWNER on.

It just looks that way in the patch for things whose names are exactly
that long because of the + at the beginning of the line pushing them
over a tab column in your mailer.  They are correct after the patch
applies.

> Hmm, well you also made some odd (inconsistent) tab+space choices at and
> following cap_clear.

Same thing.  And I'll admit that it is a bit inconsistent, but a whole
new tab just pushed things too far to the right and I didn't want to
leave 8 spaces anywhere in the file.   So that's what I came up with...
I promise it looks nice in the end   :)

> 
> thanks,
> -serge

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/