linux-kernel - Re: [git patch] free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480F3ECC.1090809@keyaccess.nl>
Date:	Wed, 23 Apr 2008 15:51:08 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Adrian Bunk <bunk@...nel.org>, Jeff Garzik <jeff@...zik.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, rmk@....linux.org.uk,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [git patch] free_irq() fixes

On 23-04-08 02:16, Linus Torvalds wrote:

> On Wed, 23 Apr 2008, Adrian Bunk wrote:
>> If it goes like the regs removal in one big patch around -rc1 into your 
>> tree this shouldn't be a problem.
> 
> Well, the regs removal had a real upside (it wasn't even sensible for all 
> irq types), and really nobody used it apart from "system users" (ie Sysrq 
> etc).
> 
> I'm still waiting for anybody mentioning any upside at _all_ on removing 
> "irq".

Saves another 4 bytes of stack? :-/ Seriously, Jeff can probably better 
answer himself but when this was posted before:

http://lkml.org/lkml/2007/5/19/23

Eric Biederman said it fit nicely into his "nefarious plan of making 
everything use a struct irq pointer". A later mention:

http://lkml.org/lkml/2007/10/19/66

got strong ACKs from Thomas Gleixner, Ingo Molnar and Greg KH. Remember due 
to working on a local driver at the time and deleting the "irq" argument 
usage from its handler (unneccesarily used in a debugging printk) from it in 
response.

My own view is that if it's not really overly painful this does make for a 
nice API cleanliness thing -- the IRQ level is only relevant to the lower 
level generic handler code not the "driver endpoint handler" and not passing 
it in the first place thereby is in keeping with this layering.

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/