linux-kernel - Re: [PATCH] PCI Express ASPM support should default to 'No'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804240833.19614.jbarnes@virtuousgeek.org>
Date:	Thu, 24 Apr 2008 08:33:19 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Jesper Juhl <jesper.juhl@...il.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] PCI Express ASPM support should default to 'No'

On Thursday, April 24, 2008 1:02 am Shaohua Li wrote:
> On Thu, 2008-04-24 at 09:49 +0200, Andi Kleen wrote:
> > Shaohua Li <shaohua.li@...el.com> writes:
> > > Ok, I'm fine with the patch. Though by default, the policy is to use
> > > BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
> >
> > Once the feature is considered stable it would be nice to make it
> > default y
> > again. I think any power saving should be on by default (unless
> > serious
> > issues are known), not off.
>
> yes, we could do it in next release.

When we move to 'default y' we should also update the Kconfig text, removing 
the experimental tag and changing the advice.

And yeah, I'd like to save power by default too, but do you think this has 
seen enough test coverage to enable it by default?  Do we know of any 
platforms where ASPM causes problems because the BIOS enabled it and we tried 
to use it?


Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/