linux-kernel - Re: [PATCH] pci: let pci_device_shutdown to call pci_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440804231911y51d2cf9bw50246a6435ae1f98@mail.gmail.com>
Date:	Wed, 23 Apr 2008 19:11:02 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	michael@...erman.id.au
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Greg KH" <greg@...ah.com>, "David Miller" <davem@...emloft.net>,
	"Jeff Garzik" <jeff@...zik.org>,
	linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"James Bottomley" <James.Bottomley@...senpartnership.com>,
	"Sathya Prakash" <sathya.prakash@....com>
Subject: Re: [PATCH] pci: let pci_device_shutdown to call pci_disable_msi

On Wed, Apr 23, 2008 at 6:22 PM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
>
> On Wed, Apr 23, 2008 at 5:17 PM, Michael Ellerman
>  <michael@...erman.id.au> wrote:
>  >  But does that help us? What if the device driver in the 2nd kernel
>  >  assumes it's using INTX, when in fact MSI is enabled on the device. In
>  >  that case none of the MSI code will even be called AFAIK.
>
>  ok. for kdump case, if driver can not use msi (?), with pci=nomsi
>  we need to call pci_intx_for_msi(dev, 1) at beginning of second kernel.
>
>  will produce another patch about that case.

attached kernel should fix second kernel by kdump doesn't have msi
support problem.

anyway kexec path doesn't need attached one, because shutdown in first
kernel already did pci_msi_shutdown and it called pci_initx_for_msi

also long term should teach every driver call pci_intx_for_msi(dev, 1)?

YH

View attachment "enable_intx_for_kdump.patch" of type "text/x-patch" (1937 bytes)