linux-kernel - Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080424001656.GM4825@implementation>
Date:	Thu, 24 Apr 2008 01:16:56 +0100
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Michael Kerrisk <mtk.manpages@...glemail.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, mtk.manpages@...il.com
Subject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen

Michael Kerrisk, le Fri 18 Apr 2008 18:52:21 +0200, a écrit :
> >>  +is
> >>  +.IR sizeof(sa_family_t) ,
> 
> Why did you write sa_family_t here?

Because to me it made more sense.

> Dave M already said sizeof(short), which is the same thing,

Ok, but that's exposing implementation.


> and I see that in net/unix/af_unix.c::unix_getname() there is:
> 
>                 *uaddr_len = sizeof(short);

I'd say that code should be fixed into using sa_family_t.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/