linux-kernel - Re: [PATCH] x86: Fix non-kernel use of include/linux/types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2008 05:20:38 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] x86: Fix non-kernel use of include/linux/types.h

On Friday 25 April 2008 02:01:01 Adrian Bunk wrote:
> On Fri, Apr 25, 2008 at 01:14:38AM +1000, Rusty Russell wrote:
> > In file included from ../../include/linux/if_tun.h:21,
> >                  from lguest.c:30:
> > ../../include/linux/types.h:203: error: expected specifier-qualifier-list
> > before ‘__kernel_daddr_t’
> >
> > This reversion was created by e40c0fe6b0b5dd16aec3c0dad311d36b19d78fd9
> > 'x86: cleanup duplicate includes' which removed the !__KERNEL__ case from
> > asm-x86/posix_types.h.
>
> I'd actually prefer my patch [1] that:
> - reverts to the 2.6.24 status quo since we shouldn't leak CONFIG_* to
>   userspace at all and
> - also fixes the same regression in unistd.h

Yep, prefer your patch too.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/