| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080423.201844.167236025.davem@davemloft.net> Date: Wed, 23 Apr 2008 20:18:44 -0700 (PDT) From: David Miller <davem@...emloft.net> To: vapier@...too.org Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Subject: Re: [PATCH] linux/atm_tcp.h: cleanup for userspace From: Mike Frysinger <vapier@...too.org> Date: Wed, 23 Apr 2008 23:03:51 -0400 > On Wednesday 23 April 2008, David Miller wrote: > > From: Mike Frysinger <vapier@...too.org> > > > The atm_tcp.h uses types from linux/atm.h, but does not include it. It > > > should also use the standard __u## types from linux/types.h rather than > > > the uint##_t types since the former can be found with the kernel already. > > > > > > Signed-off-by: Mike Frysinger <vapier@...too.org> > > > > I don't think this is a sufficient patch to solve these problems. > > it is sufficient for atm_tcp.h only. many of the network headers are broken > for userspace inclusion, so i've just been posting them one at a time as last > time i posted a large patch, no one picked it up. But you're adding an include of another file that has the problem you're supposedly fixing. If using uintN_t types is the problem, you're adding a new one for applications that include linux/atm_tcp.h, because now they'll get linux/atm.h as a side effect which does it too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists