linux-kernel - Re: [REGRESSION] x86: support for new UV apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1209138782.6899.0.camel@localhost>
Date:	Fri, 25 Apr 2008 18:53:02 +0300
From:	Priit Laes <plaes@...es.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Jack Steiner <steiner@....com>
Subject: Re: [REGRESSION] x86: support for new UV apic

Ühel kenal päeval, R, 2008-04-25 kell 11:45, kirjutas Andi Kleen:
> Ingo Molnar <mingo@...e.hu> writes:
> 
> > * Priit Laes <plaes@...es.org> wrote:
> >
> >> Hey,
> >> 
> >> I am getting two following warnings (probable one per each CPU core) 
> >> using the latest Linus's git:
> >> 
> >> WARNING: at arch/x86/kernel/genapic_64.c:86 read_apic_id+0x30/0x62()
> >> Modules linked in:
> >> Pid: 1, comm: swapper Not tainted 2.6.25-03563-gf7288b1 #20
> >
> > thanks - could you check the patch below, does it fix the warnings?
> 
> I think it would have been better to change the WARN_ON to
> 
> WARN_ON(preemptible() && num_online_cpus() > 1)
> 
> Preemption is actually ok here because this runs before the other
> CPUs are started
> 
> Alternative patch appended.

Worksforme :)

--
Priit Laes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/