linux-kernel - Re: Voyager phys_cpu_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080425161745.GA21168@cs181133002.pp.htv.fi>
Date:	Fri, 25 Apr 2008 19:17:45 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	tglx@...utronix.de, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: Voyager phys_cpu_present_map compile error

On Fri, Apr 25, 2008 at 09:50:43AM -0500, James Bottomley wrote:
> On Mon, 2008-04-21 at 22:14 +0200, Ingo Molnar wrote:
> > * Adrian Bunk <bunk@...nel.org> wrote:
> > 
> > > > +#ifndef CONFIG_X86_VOYAGER
> > > >  /* Bitmask of physically existing CPUs */
> > > >  physid_mask_t phys_cpu_present_map;
> > > > +#endif
> > > >...
> > > 
> > > Alexey noted that phys_cpu_present_map for Voyager and !Voyager also 
> > > have different types and suggested to make the Voyager one static 
> > > instead (additional renaming of the Voyager one also makes sense).
> > 
> > yep, done by the patch below.
> 
> Actually, this isn't the right patch.  The point is not to avoid the
> symbol clash, it's to let voyager identify correctly that you have a
> leaking symbol.  In this case phys_cpu_present_map is exposed outside of
> SMP.  The correct fix (and one which sweeps op other storage for
> unnecessary symbols is this):
> 
> James
> 
> ---
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index c0c68c1..d68aa53 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -12,6 +12,7 @@
>  #include <asm/mpspec.h>
>  #include <asm/apicdef.h>
>  
> +#ifdef CONIFG_X86_SMP
>...

tpyo  ;)

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/