linux-kernel - Re: [PATCH] Export __locks_copy_lock() so modular lockd builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080425230336.GC9597@fieldses.org>
Date:	Fri, 25 Apr 2008 19:03:36 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Trond.Myklebust@...app.com
Subject: Re: [PATCH] Export __locks_copy_lock() so modular lockd builds

On Fri, Apr 25, 2008 at 03:32:51PM -0700, Roland Dreier wrote:
> Commit 1a747ee0 ("locks: don't call ->copy_lock methods on return of
> conflicting locks") changed fs/lockd/svclock.c to call
> __locks_copy_lock() instead of locks_copy_lock(), but lockd can be built
> as a module and __locks_copy_lock() is not exported, which causes a
> build error
> 
>     ERROR: "__locks_copy_lock" [fs/lockd/lockd.ko] undefined!
> 
> with CONFIG_LOCKD=m.
> 
> Fix this by exporting __locks_copy_lock().

Oog, sorry.  Thaks for the fix!

> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Acked-by: J. Bruce Fields <bfields@...i.umich.edu>

> ---
>  fs/locks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index e1ea2fe..44d9a6a 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -236,6 +236,7 @@ void __locks_copy_lock(struct file_lock *new, const struct file_lock *fl)
>  	new->fl_ops = NULL;
>  	new->fl_lmops = NULL;
>  }
> +EXPORT_SYMBOL(__locks_copy_lock);
>  
>  void locks_copy_lock(struct file_lock *new, struct file_lock *fl)
>  {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/