linux-kernel - Re: [PATCH 2/3] [libata/BF54x]: Fix bug - Implement bfin ata interrupt handler to avoid "irq 68 nobody cared"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48116965.7030705@pobox.com>
Date:	Fri, 25 Apr 2008 01:17:25 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Bryan Wu <cooloney@...nel.org>
CC:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 2/3] [libata/BF54x]: Fix bug - Implement bfin ata interrupt
 handler to avoid "irq 68 nobody cared"

Bryan Wu wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
> 
> Return IRQ_HANDLED when bfin ata device is busy.
> http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3513
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>
> ---
>  drivers/ata/pata_bf54x.c |  125 ++++++++++++++++++++++++++++++++++++++++++++--
>  1 files changed, 121 insertions(+), 4 deletions(-)

AFAICS the two new functions you add should be (a) marked 'static' and 
(b) not marked 'inline'.

We avoid inline these days, preferring to let the compiler make the best 
choice for that platform/CPU.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/