linux-kernel - Re: [PATCH] WAN: Fix confusing insmod error code for C101 too.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <481173DC.6010907@garzik.org>
Date:	Fri, 25 Apr 2008 02:02:04 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Krzysztof Halasa <khc@...waw.pl>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] WAN: Fix confusing insmod error code for C101 too.

Krzysztof Halasa wrote:
> WAN: Fix confusing insmod error code for C101 too.
> 
> Signed-off-by: Krzysztof Hałasa <khc@...waw.pl>
> 
> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
> index c4c8eab..c2cc42f 100644
> --- a/drivers/net/wan/c101.c
> +++ b/drivers/net/wan/c101.c
> @@ -402,7 +402,7 @@ static int __init c101_init(void)
>  #ifdef MODULE
>  		printk(KERN_INFO "c101: no card initialized\n");
>  #endif
> -		return -ENOSYS;	/* no parameters specified, abort */
> +		return -EINVAL;	/* no parameters specified, abort */
>  	}
>  
>  	printk(KERN_INFO "%s\n", version);
> @@ -420,11 +420,11 @@ static int __init c101_init(void)
>  			c101_run(irq, ram);
>  
>  		if (*hw == '\x0')
> -			return first_card ? 0 : -ENOSYS;
> +			return first_card ? 0 : -EINVAL;
>  	}while(*hw++ == ':');
>  
>  	printk(KERN_ERR "c101: invalid hardware parameters\n");
> -	return first_card ? 0 : -ENOSYS;
> +	return first_card ? 0 : -EINVAL;
>  }
>  

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/