linux-kernel - Re: [patch 13/37] Immediate Values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080426141710.GA11939@Krystal>
Date:	Sat, 26 Apr 2008 10:17:10 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Jason Baron <jbaron@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Adrian Bunk <bunk@...sta.de>, Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>, akpm@...l.org
Subject: Re: [patch 13/37] Immediate Values - Architecture Independent Code

* Ingo Molnar (mingo@...e.hu) wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > > randconfig testing in sched-devel caught a build bug - fixed by the 
> > > patch below.
> > 
> > found another build failure - the better fix is the one below.
> 
> or rather the one below ...
> 
> ------------>
> Subject: markers: fix2
> From: Ingo Molnar <mingo@...e.hu>
> Date: Sat Apr 26 11:19:00 CEST 2008
> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Good catch, thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

> ---
>  include/linux/module.h |   13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> Index: linux/include/linux/module.h
> ===================================================================
> --- linux.orig/include/linux/module.h
> +++ linux/include/linux/module.h
> @@ -472,9 +472,6 @@ extern void print_modules(void);
>  
>  extern void module_update_markers(void);
>  
> -extern void _module_imv_update(void);
> -extern void module_imv_update(void);
> -
>  #else /* !CONFIG_MODULES... */
>  #define EXPORT_SYMBOL(sym)
>  #define EXPORT_SYMBOL_GPL(sym)
> @@ -579,15 +576,19 @@ static inline void module_update_markers
>  {
>  }
>  
> +#endif /* CONFIG_MODULES */
> +
> +#if defined(CONFIG_MODULES) && defined(CONFIG_IMMEDIATE)
> +extern void _module_imv_update(void);
> +extern void module_imv_update(void);
> +#else
>  static inline void _module_imv_update(void)
>  {
>  }
> -
>  static inline void module_imv_update(void)
>  {
>  }
> -
> -#endif /* CONFIG_MODULES */
> +#endif
>  
>  struct device_driver;
>  #ifdef CONFIG_SYSFS

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/