linux-kernel - Re: [PATCH] xfs: reduce stack usage in xfs_bmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080426202630.GG17905@one.firstfloor.org>
Date:	Sat, 26 Apr 2008 22:26:30 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	David Chinner <dgc@....com>, xfs@....sgi.com,
	Eric Sandeen <sandeen@...deen.net>,
	Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

On Sat, Apr 26, 2008 at 04:07:01PM -0400, Christoph Hellwig wrote:
> On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote:
> > Denys Vlasenko <vda.linux@...glemail.com> writes:
> > >
> > > Compile tested only.
> > 
> > You should mark the helper noinline just to prevent gcc from possibly
> > inlining it. Even if it doesn't with your current compiler inline heuristics
> > vary widely between compiler versions.
> 
> STATIC as defined by xfs already does this..

Weird. Unexpected. Different from everyone else. Is this some exercise in 
obfuscation?

But ok.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/